Declare global variables that are created elsewhere#10689
Merged
Conversation
Author
|
@tacaswell @anntzer Your review of this approach? |
anntzer
approved these changes
Mar 13, 2018
Contributor
There was a problem hiding this comment.
It's kind of funny that this placates flake8 but I guess the point is that it cannot know all the places where a global could be introduced. I think it's a reasonable compromise.
Given that the global declaration is not actually needed, I'd make the comment more explicit: "...; declaration placates pyflakes" (something like that) (otherwise someone could just remove it at some point thinking it's redundant)
cclauss
force-pushed
the
declare-globals
branch
from
d61faed to
c5d2c7f
Compare
Author
|
Comments updated as requested. |
jkseppan
approved these changes
Apr 1, 2018
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10502
PR Summary
Declare show and FigureManager as global variables because they are created by an _@Backend.export decorator at the bottom or each file. The global declaration and associated comment helps both humans and linters make sense of this non-intuitive situation.
PR Checklist