MNT: revert contour deprecations#27075
Closed
jklymak wants to merge 1 commit into
Closed
Conversation
jklymak
force-pushed
the
mnt-revert-contour-deprecations
branch
from
9ec3c40 to
60dc1f7
Compare
jklymak
force-pushed
the
mnt-revert-contour-deprecations
branch
from
60dc1f7 to
d68f01a
Compare
jklymak
force-pushed
the
mnt-revert-contour-deprecations
branch
from
d68f01a to
536582f
Compare
Contributor
|
For find_nearest_contour that won't really work, as you'd also need to undeprecate the collections property, which is accessed by its implementation (as detailed in #27070 (comment)), and then you'd need to decide whether accessing that property just permanently triggers the conversion to the old-style internal representation or not (currently it does as that's the point of the backcompat layer). If it does then that means that any ContourSet on which one calls find_nearest_contour will revert back to a state where #6139, #11464, #23080 are broken. Perhaps we should keep that discussion at #27070 though. I can't say I like keeping allsegs and allkinds around forever, but I don't really mind either. |
Member
Author
3 tasks
Member
|
I have pulled this change into #27088. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contour.allsegs,contour.allkinds, andcontour.find_nearest_contourare no longer marked for deprecation.These are useful for post-processing and perhaps extra labelling. It pins us down a bit more to have them available, but the benefit justifies the cost in my opinion.
Closes #27070 #26913