MNT: Remove pre-commit/rstcheck dependency on tomli#31648
Open
timhoffm wants to merge 1 commit into
Open
Conversation
This was only needed to support python<=3.11 and is thus not needed anymore on the main branch. I'm unclear whether we should also remove `sphinx>=1.8.1`. It's far off and I'm quite sure we do not systematically specify lower compatibility boundaries.
Member
It probably should be >=3.12, but |
Member
Author
|
Sorry, should have been "python<3.11". In full: tomllib was introduced in 3.11. So as soon as we require python>=3.11 (which we do on main), we can exclusively rely on tomllib. tomli was needed to support python<3.11. |
QuLogic
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was only needed to support python<=3.11 and is thus not needed anymore on the main branch.
I'm unclear whether we should also remove
sphinx>=1.8.1. It's far off and I'm quite sure we do not systematically specify lower compatibility boundaries.