Skip to content

@messageformat/core type definitions are incorrect #434

@jfirebaugh

Description

@jfirebaugh

lib/messageformat.d.ts uses export default, but lib/messageformat.js file uses module.exports = MessageFormat. This will cause TypeScript under the node16 module mode to think an extra .default property access is required, but that will likely fail at runtime. These types should use export = MessageFormat instead of export default.

See https://arethetypeswrong.github.io/?p=%40messageformat%2Fcore%403.4.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions