fix: add encoding='utf-8' to open() calls for non-English environments#7707
Open
yahyasaqban-lab wants to merge 1 commit into
Open
fix: add encoding='utf-8' to open() calls for non-English environments#7707yahyasaqban-lab wants to merge 1 commit into
yahyasaqban-lab wants to merge 1 commit into
Conversation
Fixes UnicodeDecodeError on Windows with non-English locales (e.g., cp950) where system default encoding differs from UTF-8. Related to microsoft#5566 Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encoding='utf-8'toopen()calls in core packages that were missing itUnicodeDecodeErroron Windows with non-English locales (e.g., Chinese cp950)playwright_controller.pyfixFiles changed
magentic-one-cli/_m1.py- config file loading (2 instances)autogen-studio/database/schema_manager.py- template and env.py handling (4 instances)autogen-studio/web/auth/manager.py- YAML config loading (1 instance)autogen-ext/experimental/.../chat_completion_client_recorder.py- session file loading (1 instance)Test plan
Related to #5566
🤖 Generated with Claude Code