Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/sqlmanagementobjects
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: microsoft/sqlmanagementobjects
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: copilot/fix-202
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 3 files changed
  • 2 contributors

Commits on Aug 22, 2025

  1. Initial plan

    Copilot committed Aug 22, 2025
    Configuration menu
    Copy the full SHA
    7541b07 View commit details
    Browse the repository at this point in the history

  2. Initial analysis and plan for fixing IgnoreForScripting issue 

    Co-authored-by: shueybubbles <[email protected]>
    @shueybubbles
    Copilot and shueybubbles committed Aug 22, 2025
    Configuration menu
    Copy the full SHA
    f19f2ac View commit details
    Browse the repository at this point in the history

  3. Fix IgnoreForScripting property to not check object state during scri… 

    …pting operations

Co-authored-by: shueybubbles <[email protected]>
    @shueybubbles
    Copilot and shueybubbles committed Aug 22, 2025
    Configuration menu
    Copy the full SHA
    05b44ba View commit details
    Browse the repository at this point in the history

  4. Fix root cause: Don't mark objects as dropped during script generation 

    Based on feedback, the original fix was incorrect. The real issue is that objects
were being marked as dropped during script generation when they should only be
marked as dropped during actual execution.

The fix changes the condition from !ExecutionManager.Recording to sp.ForDirectExecution
to properly distinguish between:
- Script generation (ForDirectExecution=false): Don't mark objects as dropped
- Actual execution (ForDirectExecution=true): Mark objects as dropped

This is the correct way to handle the issue since Scripter doesn't use Recording mode.

Co-authored-by: shueybubbles <[email protected]>
    @shueybubbles
    Copilot and shueybubbles committed Aug 22, 2025
    Configuration menu
    Copy the full SHA
    cb7a68c View commit details
    Browse the repository at this point in the history
Loading