Skip to content

report: include information about event loop itself#25906

Closed
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:node-report-loop
Closed

report: include information about event loop itself#25906
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:node-report-loop

Conversation

@addaleax

@addaleax addaleax commented Feb 3, 2019

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 3, 2019
@addaleax addaleax added the report Issues and PRs related to process.report. label Feb 3, 2019
@addaleax

addaleax commented Feb 3, 2019

Copy link
Copy Markdown
Member Author

(I’m marking this as blocked on #25910, and will update this PR to also use a hex string once that one lands.)

@addaleax addaleax added the blocked PRs that are blocked by other issues or PRs. label Feb 3, 2019
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels Feb 5, 2019
@addaleax

addaleax commented Feb 5, 2019

Copy link
Copy Markdown
Member Author

Okay, rebased this against #25910.

CI: https://ci.nodejs.org/job/node-test-pull-request/20591/

@addaleax

addaleax commented Feb 5, 2019

Copy link
Copy Markdown
Member Author

@addaleax

addaleax commented Feb 6, 2019

Copy link
Copy Markdown
Member Author

Landed in 91adbe1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants