src: clean deprecate code in agent.h#25914
Closed
gengjiawen wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
added
the
c++
Member
Author
|
@addaleax Can you review this pr ? Thanks. |
addaleax
approved these changes
Feb 6, 2019
addaleax
left a comment
addaleax
left a comment
Member
There was a problem hiding this comment.
I’d remove the reference to deprecation in the commit message – this just removes an unused declaration, right?
Member
Signed-off-by: gengjiawen <[email protected]>
gengjiawen
force-pushed
the
cleanup_redundant_agent.h
branch
from
9638a9d to
9199a38
Compare
Member
Author
|
@addaleax I have fixed the commit message. |
addaleax
approved these changes
Feb 6, 2019
jasnell
approved these changes
Feb 6, 2019
Member
Contributor
|
Landed in 0e54a0a. |
danbev
pushed a commit
that referenced
this pull request
Feb 7, 2019
Signed-off-by: gengjiawen <[email protected]> PR-URL: #25914 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Feb 7, 2019
Signed-off-by: gengjiawen <[email protected]> PR-URL: #25914 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test(Windows) passes