worker: keep stdio after exit#26017
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
This addresses review comments from nodejs#25871. Refs: nodejs#25871
Member
Author
|
/cc @nodejs/workers @sam-github |
lpinca
approved these changes
Feb 9, 2019
benjamingr
approved these changes
Feb 9, 2019
addaleax
added
the
author ready
cjihrig
approved these changes
Feb 11, 2019
Member
Author
Member
Author
|
Landed in 9e84a26 |
addaleax
added a commit
that referenced
this pull request
Feb 12, 2019
This addresses review comments from #25871. Refs: #25871 PR-URL: #26017 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax
added a commit
that referenced
this pull request
Feb 13, 2019
This addresses review comments from #25871. Refs: #25871 PR-URL: #26017 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses review comments from #25871.
Refs: #25871
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes