test: missing vtable in test when LTO is enabled#28053
Closed
AdamMajer wants to merge 1 commit into
Closed
Conversation
Member
|
I’ll try to test it out later today, but maybe it would keep the test working if we don’t implicitly mark the virtual dtor as inline? diff --git a/test/addons/uv-handle-leak/binding.cc b/test/addons/uv-handle-leak/binding.cc
index 221a12843231..4718ccc9f317 100644
--- a/test/addons/uv-handle-leak/binding.cc
+++ b/test/addons/uv-handle-leak/binding.cc
@@ -15,9 +15,11 @@ void CloseCallback(uv_handle_t* handle) {}
class ExampleOwnerClass {
public:
- virtual ~ExampleOwnerClass() {}
+ virtual ~ExampleOwnerClass();
};
+ExampleOwnerClass::~ExampleOwnerClass() {}
+
ExampleOwnerClass example_instance;
void LeakHandle(const FunctionCallbackInfo<Value>& args) { |
Contributor
Author
|
@addaleax I'll try that now and will let you know. |
Contributor
Author
|
Indeed, now it passes with GCC 9.1.1 and LTO. Can you add your change? I'll close this PR as unneeded. |
Member
|
@AdamMajer Done! #28057 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #28026
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes