Skip to content

os: refactor to use more primordials#36284

Closed
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:os-primordials
Closed

os: refactor to use more primordials#36284
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:os-primordials

Conversation

@aduh95

@aduh95 aduh95 commented Nov 26, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the os Issues and PRs related to the os subsystem. label Nov 26, 2020
@Trott

Trott commented Nov 28, 2020

Copy link
Copy Markdown
Member

Benchmark IC: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/718/

@aduh95

aduh95 commented Nov 28, 2020

Copy link
Copy Markdown
Contributor Author

Benchmark results:

                                confidence improvement accuracy (*)   (**)  (***)
os/cpus.js n=30000                              0.31 %       ±0.69% ±0.92% ±1.20%
os/loadavg.js n=5000000                        -0.15 %       ±1.22% ±1.62% ±2.11%
os/networkInterfaces.js n=10000                -0.11 %       ±4.59% ±6.12% ±7.97%

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 28, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 29, 2020 •
edited by aduh95
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34606/ ✅

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 1, 2020
@github-actions github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 1, 2020
@github-actions

github-actions Bot commented Dec 1, 2020

Copy link
Copy Markdown
Contributor

Landed in 976d6a9...e6e7084

@github-actions github-actions Bot closed this Dec 1, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 1, 2020
@aduh95 @nodejs-github-bot
os: refactor to use more primordials
e6e7084 
PR-URL: #36284
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@aduh95 aduh95 deleted the os-primordials branch December 1, 2020 14:29
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@aduh95 @danielleadams
os: refactor to use more primordials
2a24096 
PR-URL: #36284
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 8, 2020
@aduh95 @cjihrig
os: refactor to use more primordials
a864d7a 
PR-URL: nodejs#36284
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request May 16, 2021
@aduh95 @targos
os: refactor to use more primordials
1462d59 
PR-URL: #36284
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95 @targos
os: refactor to use more primordials
c442d89 
PR-URL: #36284
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. os Issues and PRs related to the os subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95 @Trott @nodejs-github-bot @lpinca