Skip to content

test-crypto-fips.js fails with shared OpenSSL 3#42947

Closed
batrla wants to merge 1 commit into
nodejs:masterfrom
batrla:master
Closed

test-crypto-fips.js fails with shared OpenSSL 3#42947
batrla wants to merge 1 commit into
nodejs:masterfrom
batrla:master

Conversation

@batrla

@batrla batrla commented May 2, 2022

Copy link
Copy Markdown
Contributor

closes #42827

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels May 2, 2022
@mhdawson

mhdawson commented May 2, 2022

Copy link
Copy Markdown
Member

@danbev can you take a look at this one?

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@tniessen tniessen requested a review from bnoordhuis May 3, 2022 13:11

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson

mhdawson commented May 4, 2022

Copy link
Copy Markdown
Member

Landed in 2454aa0

@mhdawson mhdawson closed this May 4, 2022
mhdawson pushed a commit that referenced this pull request May 4, 2022
Fixes: #42827

PR-URL: #42947
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 10, 2022
Fixes: #42827

PR-URL: #42947
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 10, 2022
@juanarbol

Copy link
Copy Markdown
Member

OpenSSL 3 is not part of v16.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test/parallel/test-crypto-fips.js fails if node is built with --shared-openssl and --openssl-is-fips

7 participants