Skip to content

test: mark test-http2-large-file flaky on aix#47410

Closed
MoLow wants to merge 1 commit into
nodejs:mainfrom
MoLow:mark-http2-large-file-as-flaky
Closed

test: mark test-http2-large-file flaky on aix#47410
MoLow wants to merge 1 commit into
nodejs:mainfrom
MoLow:mark-http2-large-file-as-flaky

Conversation

@MoLow

@MoLow MoLow commented Apr 4, 2023

Copy link
Copy Markdown
Member

a mitigation for #47409

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 4, 2023
@MoLow MoLow added fast-track PRs that do not need to wait for 72 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 4, 2023
@github-actions

github-actions Bot commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2023
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 4, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@MoLow MoLow removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2023

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@anonrig

anonrig commented Apr 5, 2023

Copy link
Copy Markdown
Member

Could we land this manually? The tests are failing because of a different issue.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@targos

targos commented Apr 6, 2023

Copy link
Copy Markdown
Member

#47450 should make this unnecessary.

@MoLow

MoLow commented Apr 6, 2023

Copy link
Copy Markdown
Member Author

closing in favor of #47450

@MoLow MoLow closed this Apr 6, 2023
@MoLow MoLow deleted the mark-http2-large-file-as-flaky branch April 6, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 72 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants