Skip to content

[v18.x] lib: fix trailing commas and leftover function from rebasing #47503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danielleadams wants to merge 1 commit into from
Closed

[v18.x] lib: fix trailing commas and leftover function from rebasing #47503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: fix trailing commas and leftover function from rebasing
  • Loading branch information
@danielleadams
danielleadams committed Apr 11, 2023
commit 2de9651d3a6b6e9ad8f402c931d9a115528134cc
8 changes: 2 additions & 6 deletions lib/internal/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ const {
kPathStart,
kPort,
kQuery,
kSchemeStart
kSchemeStart,
} = internalBinding('url');

const {
Expand Down Expand Up @@ -641,10 +641,6 @@ function onParseHashComplete(flags, protocol, username, password,
this[context].fragment = fragment;
}

function isURLThis(self) {
return (self !== undefined && self !== null && self[context] !== undefined);
}

class URL {
constructor(input, base = undefined) {
// toUSVString is not needed.
Expand Down Expand Up @@ -718,7 +714,7 @@ class URL {
unicode: false,
search: true,
auth: true,
...options
...options,
};
const ctx = this[context];
// https://url.spec.whatwg.org/#url-serializing
Expand Down
2 changes: 1 addition & 1 deletion lib/timers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const {

const {
immediateInfo,
toggleImmediateRef
toggleImmediateRef,
} = internalBinding('timers');
const L = require('internal/linkedlist');
const {
Expand Down