Skip to content

test: use PYTHON executable from env in assertSnapshot #53938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jul 21, 2024
Merged

test: use PYTHON executable from env in assertSnapshot #53938

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13a27c2
test: use `PYTHON` executable from env in `assertSnapshot`
aduh95 Jul 19, 2024
7611092
fixup!
aduh95 Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: use PYTHON executable from env in assertSnapshot
  • Loading branch information
@aduh95
aduh95 committed Jul 19, 2024
commit 13a27c22582b81a8cef5bee4b1624b757918e027
4 changes: 2 additions & 2 deletions test/common/assertSnapshot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ async function spawnAndAssert(filename, transform = (x) => x, { tty = false, ...
return;
}
const flags = common.parseTestFlags(filename);
const executable = tty ? path.join(__dirname, '../..', 'tools/pseudo-tty.py') : process.execPath;
const args = tty ? [process.execPath, ...flags, filename] : [...flags, filename];
const executable = tty ? (process.env.PYTHON || 'python3') : process.execPath;
const args = tty ? [path.join(__dirname, '../..', 'tools/pseudo-tty.py'), process.execPath, ...flags, filename] : [...flags, filename];
Comment thread
aduh95 marked this conversation as resolved.
Outdated
const { stdout, stderr } = await common.spawnPromisified(executable, args, options);
await assertSnapshot(transform(`${stdout}${stderr}`), filename);
}
Expand Down