Skip to content

doc: update require(ESM) history and stability status#55199

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:require-esm-history
Oct 2, 2024
Merged

doc: update require(ESM) history and stability status#55199
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:require-esm-history

Conversation

@aduh95

@aduh95 aduh95 commented Sep 30, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@aduh95 aduh95 requested a review from joyeecheung September 30, 2024 20:56
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Sep 30, 2024
@aduh95 aduh95 added backport-requested-v20.x backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. labels Sep 30, 2024
@avivkeller avivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 1, 2024
Comment thread doc/api/modules.md Outdated
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 1, 2024
@aduh95 aduh95 force-pushed the require-esm-history branch from 6d31676 to 78063b0 Compare October 2, 2024 14:59
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 2, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/55199
✔  Done loading data for nodejs/node/pull/55199
----------------------------------- PR info ------------------------------------
Title      doc: update `require(ESM)` history and stability status (#55199)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:require-esm-history -> nodejs:main
Labels     doc, module, author ready, commit-queue-squash, backport-requested-v20.x, backport-requested-v22.x
Commits    1
 - doc: update `require(ESM)` history and stability status
Committers 1
 - Antoine du Hamel <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/55199
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55199
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - doc: update `require(ESM)` history and stability status
   ℹ  This PR was created on Mon, 30 Sep 2024 20:56:15 GMT
   ✔  Approvals: 3
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/55199#pullrequestreview-2338676190
   ✔  - Guy Bedford (@guybedford): https://github.com/nodejs/node/pull/55199#pullrequestreview-2338931035
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/55199#pullrequestreview-2340448665
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/11151507870

@aduh95 aduh95 merged commit 348d865 into nodejs:main Oct 2, 2024
@aduh95

aduh95 commented Oct 2, 2024

Copy link
Copy Markdown
Contributor Author

Landed in 348d865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v22.x PRs backported to the v22.x-staging branch. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants