Skip to content

Retry without ssl even on error response #6601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vonzshik wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

Retry without ssl even on error response #6601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Npgsql/Internal/NpgsqlConnector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,8 +556,8 @@ static async Task OpenCore(
//
// Any error after trying with GSS encryption
(gssEncMode == GssEncryptionMode.Prefer ||
// Auth error with/without SSL
(sslMode == SslMode.Prefer && conn.IsSslEncrypted || sslMode == SslMode.Allow && !conn.IsSslEncrypted))
// Any error after trying with/without SSL but we're allowed to retry
sslMode == SslMode.Prefer || sslMode == SslMode.Allow)
{
if (gssEncMode == GssEncryptionMode.Prefer)
{
Expand Down Expand Up @@ -970,6 +970,10 @@ async Task SetupEncryption(SslMode sslMode, GssEncryptionMode gssEncryptionMode,
var response = (char)ReadBuffer.ReadByte();
timeout.CheckAndApply(this);

// TODO: Server can respond with an error here
// but according to documentation we shouldn't display this error to the user/application
// since the server has not been authenticated (CVE-2024-10977)
// See https://www.postgresql.org/docs/current/protocol-flow.html#PROTOCOL-FLOW-SSL
switch (response)
{
default:
Expand Down
Loading