Skip to content

move cgroup pool creation logic to init#412

Merged
tylerharter merged 8 commits into
open-lambda:mainfrom
m0mosenpai:cgroup-pool-init
Feb 20, 2026
Merged

move cgroup pool creation logic to init#412
tylerharter merged 8 commits into
open-lambda:mainfrom
m0mosenpai:cgroup-pool-init

Conversation

@m0mosenpai
Copy link
Copy Markdown
Contributor

@m0mosenpai m0mosenpai commented Feb 17, 2026

  • init creates the cgroup pool root dir, enables controllers and chowns to the original user (from /proc/self/loginuid)
  • NewCgroupPool() verifies the pool root exists instead of creating it
  • GroupPath() computes the cgroup path from the worker directory
  • Destroy() removes child cgroups but preserves the pool root
  • Dirty cleanup no longer removes the pool root

Copy link
Copy Markdown
Member

@tylerharter tylerharter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Comment thread go/worker/helpers.go Outdated
Comment thread go/worker/helpers.go Outdated
Comment thread go/worker/helpers.go Outdated
Comment thread go/worker/commands.go
Copy link
Copy Markdown
Member

@tylerharter tylerharter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Mostly minor feedback

Comment thread go/common/user.go Outdated
Comment thread go/common/user.go Outdated
Comment thread go/worker/sandbox/cgroups/pool.go Outdated
Comment thread go/worker/sandbox/cgroups/pool.go Outdated
Comment thread go/worker/commands.go Outdated
Comment thread go/common/user.go Outdated
Comment thread go/worker/sandbox/cgroups/pool.go Outdated
Comment thread go/worker/commands.go Outdated
@tylerharter tylerharter merged commit a268288 into open-lambda:main Feb 20, 2026
1 of 2 checks passed
m0mosenpai added a commit to m0mosenpai/open-lambda that referenced this pull request Apr 16, 2026
This reverts commit a268288.

cgroups need to be managed by the worker itself
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants