Skip to content

Revert "move cgroup pool creation logic to init (#412)"#446

Open
m0mosenpai wants to merge 1 commit into
open-lambda:mainfrom
m0mosenpai:revert-cgroup-root-init
Open

Revert "move cgroup pool creation logic to init (#412)"#446
m0mosenpai wants to merge 1 commit into
open-lambda:mainfrom
m0mosenpai:revert-cgroup-root-init

Conversation

@m0mosenpai
Copy link
Copy Markdown
Contributor

This reverts commit a268288.

cgroups need to be managed by the worker itself - worker is unable to add its own PID into the child cgroup due to a violation of the cgroupv2 common ancestor rule. Workaround will be as follows:

  • The worker will manage its own cgroups like before.
  • We will use systemd to get a user delegated space for creating/managing cgroups by default, with the option of configuring a custom pool path (user will be responsible for making sure the custom path meets all the requirements for the worker to function)

This reverts commit a268288.

cgroups need to be managed by the worker itself
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant