Feature/upgrade oxyplot.skiasharp#2161
Conversation
VisualMelon
left a comment
VisualMelon
left a comment
There was a problem hiding this comment.
Thanks for looking into this. I'm hoping to find the time and energy soon to deal with this sort of thing, so feel free to @ me directly if I'm slow to respond, but it's going to take time for me to review everything and work out how nuget works again etc. etc.
|
@VisualMelon I went through your comments, posted responses and made the necessary changes |
|
@VisualMelon any new comments to this? |
|
@VisualMelon how likely is it this will be merged in and we can have a new release of oxyplot.skiasharp before mid-may? All the best, |
|
I applied the proposed changes to my https://github.com/AndreCL/Oxyplot.DotNetAndroid project (just as a copy of the code) and it works perfectly fine in https://play.google.com/store/apps/details?id=eu.luanca.Century |
|
@AndreCL given the Android problem, I'll try to find time to look at this in the next couple of days, but I can't make any promises. Please keep pestering me. |
|
Version numbering is something we've never been very good at: I think to keep things simple, we bump dependencies, .NET to 8/10, Avalonia to v12, and look to release everything as 2.3.0 |
|
Have approved the CI, but don't have time to check it will actually work now: will try to check back later today and hopefully we won't need to fight with it (but there is a good chance we will) |
|
Need to bump ImageSharp, probably to 2.1.13 for the time being |
|
@VisualMelon I did the modification you commented on code. Something else I should do? |
|
@AndreCL I'm probably too busy to look at this properly again until early next week; hopefully the CI will at least be happy now |
|
@VisualMelon I saw there were 2 workflows that failed because SixLabors.ImageSharp version in the OxyPlot.ImageSharp solution also had vulnerabilities, so I have added the upgrade of that too here so they can pass. Can you please review and retrigger the workflows? |
… dependency groups to include an explicit platform version)
|
@VisualMelon I (hopefully) fixed the NU1012 error that was in the windows projects during the pipeline run |
2 participants
Fixes # .
The goal was to upgrade some nuget packages in Oxyplot.Skiasharp that had some problems.
#2160
And packages with vulnerabilities
For that purpose:
Hoping it can be used for a needed new release of Oxyplot.Skiasharp nuget
Checklist
Changes proposed in this pull request:
@oxyplot/admins