Fix for #18

jeffharrell · jeffharrell · commit 9a963de21299 · 2013-03-17T21:53:08.000-07:00
diff --git a/dist/paypal-button-minicart.js b/dist/paypal-button-minicart.js
@@ -1,7 +1,7 @@
 /*!
  * PayPalJSButtons
  * JavaScript integration for PayPal's payment buttons
- * @version 1.0.0 - 2013-03-15
+ * @version 1.0.0 - 2013-03-17
  * @author Jeff Harrell <https://github.com/jeffharrell/>
  */
 /*!
@@ -1993,7 +1993,7 @@ PAYPAL.apps = PAYPAL.apps || {};
 			for (i = 0, len = attrs.length; i < len; i++) {
 				attr = attrs[i];
 
-				if ((matches = /^data-([a-z0-9]+)(-editable)?/i.exec(attr.name))) {
+				if ((matches = /^data-([a-z0-9_]+)(-editable)?/i.exec(attr.name))) {
 					dataset[matches[1]] = {
 						value: attr.value,
 						isEditable: !!matches[2]
diff --git a/dist/paypal-button-minicart.min.js b/dist/paypal-button-minicart.min.js
diff --git a/dist/paypal-button.js b/dist/paypal-button.js
@@ -1,7 +1,7 @@
 /*!
  * PayPalJSButtons
  * JavaScript integration for PayPal's payment buttons
- * @version 1.0.0 - 2013-03-15
+ * @version 1.0.0 - 2013-03-17
  * @author Jeff Harrell <https://github.com/jeffharrell/>
  */
 if (typeof PAYPAL === 'undefined' || !PAYPAL) {
@@ -260,7 +260,7 @@ PAYPAL.apps = PAYPAL.apps || {};
 			for (i = 0, len = attrs.length; i < len; i++) {
 				attr = attrs[i];
 
-				if ((matches = /^data-([a-z0-9]+)(-editable)?/i.exec(attr.name))) {
+				if ((matches = /^data-([a-z0-9_]+)(-editable)?/i.exec(attr.name))) {
 					dataset[matches[1]] = {
 						value: attr.value,
 						isEditable: !!matches[2]
diff --git a/dist/paypal-button.min.js b/dist/paypal-button.min.js
diff --git a/src/paypal-button.js b/src/paypal-button.js
@@ -254,7 +254,7 @@ PAYPAL.apps = PAYPAL.apps || {};
 			for (i = 0, len = attrs.length; i < len; i++) {
 				attr = attrs[i];
 
-				if ((matches = /^data-([a-z0-9]+)(-editable)?/i.exec(attr.name))) {
+				if ((matches = /^data-([a-z0-9_]+)(-editable)?/i.exec(attr.name))) {
 					dataset[matches[1]] = {
 						value: attr.value,
 						isEditable: !!matches[2]
diff --git a/test/index.html b/test/index.html
@@ -32,6 +32,7 @@ <h2>Buy Now (Spanish)</h2>
 		    data-name="Buy now!"
 		    data-amount="1.00"
 		    data-lang="es_ES"
+		    data-currency_code="EUR"
 		></script>
 	</div>
 
@@ -42,6 +43,7 @@ <h2>Buy Now (French)</h2>
 		    data-name="Buy now!"
 		    data-amount="1.00"
 		    data-lang="fr_FR"
+		    data-currency_code="EUR"
 		></script>
 	</div>
 
@@ -52,6 +54,7 @@ <h2>Buy Now (German)</h2>
 		    data-name="Buy now!"
 		    data-amount="1.00"
 		    data-lang="de_DE"
+		    data-currency_code="EUR"
 		></script>
 	</div>
 
