Fix syntax error in test PropertyHook#712
Merged
Merged
Conversation
Contributor
Author
|
The failing tests also fail on the 6.x branch so are not related to this PR |
Member
|
can you please rebase against 7.x, so we can proceed an merge this. |
Contributor
Author
|
Done, please merge before 8.0 :D |
Member
|
Thanks a lot. I will make sure this is merged soon. |
Contributor
Author
|
Thanks, for context we are using this as a test case in pdepend / phpmd so not having false parser errors nice a nice. |
Member
|
Do you need a release for that? |
Contributor
Author
|
That might be the case, but don't worry about it, for now it's a manual process, and it needs to spread though our dependency tree as well, so don't sweat it, just wanted to let you know another way this project is helping others :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php -l
Cannot specify default value for virtual hooked property