[ticket/17607] Add missing COULD_NOT_COPY language key#6968
Open
ECYaz wants to merge 1 commit into
Open
Conversation
|
The attempt to merge branch
This PR is ready to be merged. |
Crizz0
reviewed
Jun 22, 2026
| // Common converter messages | ||
| 'CONVERT_NOT_EXIST' => 'The specified convertor does not exist.', | ||
| 'DEV_NO_TEST_FILE' => 'No value has been specified for the test_file variable in the convertor. If you are a user of this convertor, you should not be seeing this error, please report this message to the convertor author. If you are a convertor author, you must specify the name of a file which exists in the source board to allow the path to it to be verified.', | ||
| 'COULD_NOT_COPY' => 'Could not copy file <strong>%1$s</strong> to <strong>%2$s</strong><br /><br />Please check that the target directory exists and is writable by the webserver.', |
Author
There was a problem hiding this comment.
Done, switched to <br>. Thanks for the review!
copy_file() in includes/functions_convert.php references $user->lang['COULD_NOT_COPY'] when a file copy fails during a board conversion, but the key was missing from language/en/install.php, producing a broken/empty error message. Restore it with the %1$s/%2$s source/target placeholders copy_file() passes. PHPBB-17607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The convertor's
copy_file()(includes/functions_convert.php) callssprintf($user->lang['COULD_NOT_COPY'], ...)when a file copy fails during a board conversion, but theCOULD_NOT_COPYkey was missing fromlanguage/en/install.php, producing a broken/empty error message. This restores it.Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17607