fix: Prevent infinite loop#2875
Open
michael-grunder wants to merge 1 commit into
Open
Conversation
I've created an "evil" RESP server that intentionally returns malformed RESP replies and lies about `MOVED`/`ASKING` slots. That surfaced a possible DOS bug where a malicous cluster could cause PhpRedis to spin forever. This fixes that issue.
yatsukhnenko
approved these changes
Jun 18, 2026
Comment on lines
+121
to
+123
| zend_throw_exception_ex(redis_cluster_exception_ce, 0, | ||
| "protocol error, invalid reply length"); | ||
| return FAILURE; |
Member
There was a problem hiding this comment.
Suggested change
| zend_throw_exception_ex(redis_cluster_exception_ce, 0, | |
| "protocol error, invalid reply length"); | |
| return FAILURE; | |
| goto failure; |
Comment on lines
+129
to
+131
| zend_throw_exception_ex(redis_cluster_exception_ce, 0, | ||
| "protocol error, invalid reply length"); | ||
| return FAILURE; |
Member
There was a problem hiding this comment.
Suggested change
| zend_throw_exception_ex(redis_cluster_exception_ce, 0, | |
| "protocol error, invalid reply length"); | |
| return FAILURE; | |
| goto failure; |
| } | ||
|
|
||
| c->reply_len = n; | ||
| return SUCCESS; |
Member
There was a problem hiding this comment.
Suggested change
| return SUCCESS; | |
| return SUCCESS; | |
| failure: | |
| zend_throw_exception_ex(redis_cluster_exception_ce, 0, | |
| "protocol error, invalid reply length"); | |
| return FAILURE; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created an "evil" RESP server that intentionally returns malformed RESP replies and lies about
MOVED/ASKINGslots.That surfaced a possible DOS bug where a malicous cluster could cause PhpRedis to spin forever.
This fixes that issue.