Skip to content

gh-108590: Fix sqlite3.iterdump for invalid unicode in text columns and reproducability. #108695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CorvinM wants to merge 8 commits into from
Closed

gh-108590: Fix sqlite3.iterdump for invalid unicode in text columns and reproducability. #108695

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a689bbd
gh-108590: Fix sqlite3.iterdump for invalid unicode in text columns.
CorvinM Aug 29, 2023
03f41df
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 29, 2023
e2939d5
Update Misc/NEWS.d/next/Library/2023-08-29-22-53-48.gh-issue-108590.6…
CorvinM Aug 30, 2023
0643ffc
Update Lib/sqlite3/dump.py
CorvinM Aug 30, 2023
608d919
Address comments
CorvinM Aug 30, 2023
cc7fba8
Use contextmanager
CorvinM Aug 30, 2023
c1b730d
Style nits and a comment
erlend-aasland Aug 30, 2023
365b16e
Add dump reproducability test
CorvinM Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Misc/NEWS.d/next/Library/2023-08-29-22-53-48.gh-issue-108590.6… 
…k0pOl.rst

Co-authored-by: Erlend E. Aasland <[email protected]>
  • Loading branch information
@CorvinM @erlend-aasland
CorvinM and erlend-aasland authored Aug 30, 2023
commit e2939d58c5e75cd5e997a37337ea38ea0f8bb23d
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Library/2023-08-29-22-53-48.gh-issue-108590.6k0pOl.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Fixed an issue causing sqlite3.iterdump to crash when encountering invalid unicode in a TEXT column.
Fixed an issue where :meth:`sqlite3.Connection.iterdump` would fail and leave an incomplete SQL dump if a table includes invalid Unicode sequences.