bpo-36347: Renaming the constants for the .flags of PyMemberDef#12410
bpo-36347: Renaming the constants for the .flags of PyMemberDef#12410matrixise wants to merge 11 commits into
Conversation
|
This is nice, it makes the field far less opaque and improve readability. Do you think we could change those who are set to |
|
@remilapeyre we could do it, but I prefer to avoid because it's a big change. This is the same thing with the f-string, you can use the f-string for the new development, not for the existing, excepted if you refactor the code. |
|
just for |
|
Ok, I think it's a bit less intrusive than for f-string because there still is some places where it's more readable to use other format strings but your patch would improve readability everywhere. You are right that it can be done in another PR and that it's better to wait for the feedback of a core dev anyway. |
|
restart the build... |
|
I close this PR, I think it's a bad practice to create a big PR with a lot of modifications. |
https://bugs.python.org/issue36347