Skip to content

bpo-36347: Renaming the constants for the .flags of PyMemberDef#12410

Closed
matrixise wants to merge 11 commits into
python:masterfrom
matrixise:bpo-36347
Closed

bpo-36347: Renaming the constants for the .flags of PyMemberDef#12410
matrixise wants to merge 11 commits into
python:masterfrom
matrixise:bpo-36347

Conversation

@matrixise

@matrixise matrixise commented Mar 18, 2019

Copy link
Copy Markdown
Member

@remilapeyre

Copy link
Copy Markdown

This is nice, it makes the field far less opaque and improve readability. Do you think we could change those who are set to 0 to replace them by READWRITE in the same PR?

@matrixise

Copy link
Copy Markdown
Member Author

@remilapeyre we could do it, but I prefer to avoid because it's a big change. This is the same thing with the f-string, you can use the f-string for the new development, not for the existing, excepted if you refactor the code.

@matrixise

matrixise commented Mar 18, 2019

Copy link
Copy Markdown
Member Author

just for Modules, Objects we have ~77 definitions of members. I prefer to wait for the feedback of the core-dev and after create a new PR with this change (if they agree with this change).

@remilapeyre

Copy link
Copy Markdown

Ok, I think it's a bit less intrusive than for f-string because there still is some places where it's more readable to use other format strings but your patch would improve readability everywhere. You are right that it can be done in another PR and that it's better to wait for the feedback of a core dev anyway.

@matrixise

Copy link
Copy Markdown
Member Author

restart the build...

@matrixise matrixise requested review from a team, 1st1 and rhettinger as code owners March 19, 2019 15:10
@matrixise matrixise changed the title bpo-36347: Add the READWRITE constant in structmember.h bpo-36347: Renaming the constants for the .m_flags of PyMemberDef Mar 19, 2019
@matrixise matrixise changed the title bpo-36347: Renaming the constants for the .m_flags of PyMemberDef bpo-36347: Renaming the constants for the .flags of PyMemberDef Mar 19, 2019
@matrixise

Copy link
Copy Markdown
Member Author

I close this PR, I think it's a bad practice to create a big PR with a lot of modifications.

@matrixise matrixise closed this Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants