Skip to content

gh-124785: re-work fix so tracerefs test passes #124808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nascheme wants to merge 3 commits into from
Closed

gh-124785: re-work fix so tracerefs test passes #124808

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8bf7d9
gh-124785: re-work fix so tracerefs test passes
nascheme Sep 30, 2024
fe6adde
Update Objects/unicodeobject.c
nascheme Sep 30, 2024
1d0b7c1
Minor code cleanup as suggested by review.
nascheme Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Minor code cleanup as suggested by review.
  • Loading branch information
@nascheme
nascheme committed Oct 1, 2024
commit 1d0b7c1a3e9e33f03f8adc9a53d3f050b1bbee40
3 changes: 1 addition & 2 deletions Objects/unicodeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,6 @@ clear_interned_dict_legacy(PyInterpreterState *interp)
Py_ssize_t pos = 0;
PyObject *s, *ignored_value;
while (PyDict_Next(interned, &pos, &s, &ignored_value)) {
assert(PyUnicode_IS_READY(s));
#ifdef Py_TRACE_REFS
_Py_AddToAllObjects(s);
#endif
Expand All @@ -381,7 +380,7 @@ clear_interned_dict_legacy(PyInterpreterState *interp)
#endif
break;
case SSTATE_NOT_INTERNED:
/* fall through */
_Py_FALLTHROUGH;
default:
Py_UNREACHABLE();
}
Expand Down