Skip to content

gh-130004: Revert commit 9e52e55#130005

Merged
Fidget-Spinner merged 1 commit into
python:mainfrom
Fidget-Spinner:revert-129263
Feb 11, 2025
Merged

gh-130004: Revert commit 9e52e55#130005
Fidget-Spinner merged 1 commit into
python:mainfrom
Fidget-Spinner:revert-129263

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Feb 11, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@Fidget-Spinner Fidget-Spinner requested review from a team and markshannon as code owners February 11, 2025 14:29
@bedevere-app bedevere-app Bot mentioned this pull request Feb 11, 2025
Closed
@Fidget-Spinner Fidget-Spinner requested review from hugovk and mdboom and removed request for a team and markshannon February 11, 2025 14:29
@Yhg1s

Yhg1s commented Feb 11, 2025

Copy link
Copy Markdown
Member

For reference (and cross-referencing): this reverts PR #129263.

@StanFromIreland

StanFromIreland commented Feb 11, 2025

Copy link
Copy Markdown
Member

This PR was one off the numbers aligning :-(!

@Fidget-Spinner Fidget-Spinner requested a review from ambv February 11, 2025 15:13
@zooba

zooba commented Feb 11, 2025

Copy link
Copy Markdown
Member

Change looks fine to me.

If we know the value of _MSC_VER where the fix was added, we could make that part of the condition.

@Fidget-Spinner

Fidget-Spinner commented Feb 11, 2025

Copy link
Copy Markdown
Member Author

Change looks fine to me.

If we know the value of _MSC_VER where the fix was added, we could make that part of the condition.

Let's leave that till after so the release isn't blocked.

@mdboom

mdboom commented Feb 11, 2025

Copy link
Copy Markdown
Contributor

If we know the value of _MSC_VER where the fix was added, we could make that part of the condition.

I'm trying to determine that -- we use the preview compiler internally for our benchmarking and it's fixed there, but I'll try to determine the non-preview release it shipped on. @zooba: I'll send you the (private) bug link and maybe you understand how to follow the breadcrumbs...

@Fidget-Spinner Fidget-Spinner merged commit 247b50d into python:main Feb 11, 2025
@Fidget-Spinner Fidget-Spinner deleted the revert-129263 branch February 11, 2025 15:24
@Fidget-Spinner Fidget-Spinner mentioned this pull request Feb 12, 2025
Merged
zanieb added a commit to astral-sh/python-build-standalone that referenced this pull request Feb 12, 2025
@zanieb
Apply the patches from python/cpython#130005 too
931f432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

@mdboom mdboom Awaiting requested review from mdboom

@ambv ambv Awaiting requested review from ambv

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Fidget-Spinner @Yhg1s @StanFromIreland @zooba @mdboom @hugovk