Skip to content

gh-133653: Fix subclassing HelpFormatter #133668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hugovk wants to merge 3 commits into from
Closed

gh-133653: Fix subclassing HelpFormatter #133668

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1c0c60
Fix subclassing HelpFormatter
hugovk May 8, 2025
fa4d044
Fix Sphinx warning
hugovk May 8, 2025
91c1f4f
Big if
hugovk May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Big if
  • Loading branch information
@hugovk
hugovk committed May 8, 2025
commit 91c1f4fe19dc69075b28f2ea2e8e4a662e5e5370
14 changes: 12 additions & 2 deletions Lib/argparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2723,13 +2723,23 @@ def format_help(self):
return formatter.format_help()

def _get_formatter(self):
try:
import inspect
if len(
[v.kind for (k, v) in
inspect.signature(self.formatter_class).parameters.items()
if k in ('prefix_chars', 'color')
and v.kind in (
inspect._ParameterKind.POSITIONAL_OR_KEYWORD,
inspect._ParameterKind.KEYWORD_ONLY,
)
]
) == 2:
return self.formatter_class(
prog=self.prog,
prefix_chars=self.prefix_chars,
color=self.color,
)
except TypeError:
else:
return self.formatter_class(prog=self.prog)

# =====================
Expand Down