Skip to content

gh-135953: Add flamegraph reporter to sampling profiler #138304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lkollar wants to merge 19 commits into from
Closed

gh-135953: Add flamegraph reporter to sampling profiler #138304

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f82c991
Remove unused variables in sample profiler
lkollar Aug 27, 2025
e7ff0d1
Add HTML flamegraph to sampling profiler
lkollar Aug 27, 2025
a9b1213
Avoid displaying popup outside viewport
lkollar Aug 31, 2025
e1c56ee
fixup! Add HTML flamegraph to sampling profiler
lkollar Aug 31, 2025
3a64277
Vendor D3 files and Python logo
lkollar Sep 7, 2025
e5139c7
Update Makefile.pre.in
lkollar Sep 7, 2025
37134d8
Move licenses into license.rst
lkollar Sep 7, 2025
09d04fa
Update license.rst
lkollar Sep 7, 2025
3799731
Update license.rst
lkollar Sep 7, 2025
4f10915
fixup! Update license.rst
pablogsal Sep 8, 2025
fb48a88
fixup! fixup! Update license.rst
pablogsal Sep 8, 2025
8882b27
fixup! fixup! fixup! Update license.rst
pablogsal Sep 8, 2025
738bd0a
Update Lib/test/test_profiling/test_sampling_profiler.py
lkollar Sep 9, 2025
4e63501
Shorten lines in flamegraph.js
lkollar Sep 9, 2025
eef995d
Watch for readystate before initialising flamegraph UI
lkollar Sep 9, 2025
97474d6
Add .min.js to .gitattributes
lkollar Sep 9, 2025
8291df0
Break up large functions in flamegraph.js
lkollar Sep 9, 2025
a780144
Use importlib.resources to locate flamegraph assets
lkollar Sep 9, 2025
9d3956d
fixup! Update Lib/test/test_profiling/test_sampling_profiler.py
lkollar Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fixup! fixup! Update license.rst
  • Loading branch information
@pablogsal @lkollar
pablogsal authored and lkollar committed Sep 9, 2025
commit 8882b2755989facbc499c9db3f336b701f89893b
58 changes: 32 additions & 26 deletions Lib/profiling/sampling/flamegraph.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ body {
align-items: center;
justify-content: center;
text-align: center;
gap: 20px;
}

.python-logo {
Expand Down Expand Up @@ -61,6 +62,37 @@ body {
font-weight: 300;
}

.header-search {
width: 100%;
max-width: 500px;
}

.header-search #search-input {
width: 100%;
padding: 12px 20px;
border: 2px solid rgba(255, 255, 255, 0.2);
border-radius: 25px;
font-size: 16px;
font-family: inherit;
background: rgba(255, 255, 255, 0.95);
color: #2e3338;
transition: all 0.3s ease;
box-shadow: 0 4px 12px rgba(0, 0, 0, 0.1);
backdrop-filter: blur(10px);
}

.header-search #search-input:focus {
outline: none;
border-color: rgba(255, 255, 255, 0.8);
background: rgba(255, 255, 255, 1);
box-shadow: 0 6px 20px rgba(0, 0, 0, 0.15);
transform: translateY(-2px);
}

.header-search #search-input::placeholder {
color: #6c757d;
}

.stats-section {
background: #ffffff;
padding: 24px 0;
Expand Down Expand Up @@ -164,32 +196,6 @@ body {
text-align: center;
}

.search-container {
max-width: 1200px;
margin: 16px auto 0 auto;
padding: 0 24px;
text-align: center;
}

#search-input {
padding: 12px 20px;
border: 2px solid #e9ecef;
border-radius: 6px;
font-size: 14px;
font-family: inherit;
background: white;
transition: all 0.2s ease;
box-shadow: 0 2px 4px rgba(0, 0, 0, 0.06);
display: inline-block;
width: auto;
min-width: 300px;
}

#search-input:focus {
outline: none;
border-color: #3776ab;
box-shadow: 0 4px 12px rgba(55, 118, 171, 0.2);
}

.controls button {
background: #3776ab;
Expand Down
12 changes: 6 additions & 6 deletions Lib/profiling/sampling/flamegraph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,16 +281,16 @@ document.addEventListener("DOMContentLoaded", function () {

// Update search input style based on results
if (matchCount > 0) {
searchInput.style.borderColor = "#28a745";
searchInput.style.boxShadow = "0 0 0 3px rgba(40, 167, 69, 0.1)";
searchInput.style.borderColor = "rgba(40, 167, 69, 0.8)";
searchInput.style.boxShadow = "0 6px 20px rgba(40, 167, 69, 0.2)";
} else {
searchInput.style.borderColor = "#dc3545";
searchInput.style.boxShadow = "0 0 0 3px rgba(220, 53, 69, 0.1)";
searchInput.style.borderColor = "rgba(220, 53, 69, 0.8)";
searchInput.style.boxShadow = "0 6px 20px rgba(220, 53, 69, 0.2)";
}
} else {
// Reset search input style
searchInput.style.borderColor = "#e9ecef";
searchInput.style.boxShadow = "0 2px 4px rgba(0, 0, 0, 0.06)";
searchInput.style.borderColor = "rgba(255, 255, 255, 0.2)";
searchInput.style.boxShadow = "0 4px 12px rgba(0, 0, 0, 0.1)";
}
}

Expand Down
8 changes: 4 additions & 4 deletions Lib/profiling/sampling/flamegraph_template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,14 @@
<div class="header-content">
<div class="python-logo"><!-- INLINE_LOGO --></div>
<div class="header-text">
<h1>Python Performance Flamegraph</h1>
<h1>Tachyon Profiler Performance Flamegraph</h1>
<div class="subtitle">
Interactive visualization of function call performance
</div>
</div>
<div class="header-search">
<input type="text" id="search-input" placeholder="🔍 Search functions..." />
</div>
</div>
</div>

Expand Down Expand Up @@ -61,9 +64,6 @@ <h1>Python Performance Flamegraph</h1>
<button onclick="exportSVG()" class="secondary">📁 Export SVG</button>
<button onclick="toggleLegend()">🔥 Heat Map Legend</button>
</div>
<div class="search-container">
<input type="text" id="search-input" placeholder="🔍 Search functions..." />
</div>
</div>

<button id="show-info-btn" title="Show navigation guide">&#8505;</button>
Expand Down