Skip to content

gh-140505: Correct "parameters" to "arguments" in MultiCall doc#140512

Open
7576457 wants to merge 4 commits into
python:mainfrom
7576457:fix/140505
Open

gh-140505: Correct "parameters" to "arguments" in MultiCall doc#140512
7576457 wants to merge 4 commits into
python:mainfrom
7576457:fix/140505

Conversation

@7576457

@7576457 7576457 commented Oct 23, 2025

Copy link
Copy Markdown

@python-cla-bot

python-cla-bot Bot commented Oct 23, 2025

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be changed in more places.

@7576457

7576457 commented Oct 23, 2025

Copy link
Copy Markdown
Author

I think this should be changed in more places.

Yes, you’re right -- I found one more place where the term should be updated. Everything else seems fine
изображение

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are more:

This method takes one parameter,

Signatures themselves are restricted to the top level parameters expected by a
method. For instance if a method expects one array of structs as a parameter,

And most likely:

a client can call methods with parameters

Method has parameters, but it expects and takes arguments.

@7576457

7576457 commented Oct 25, 2025

Copy link
Copy Markdown
Author

I think there are more:

This method takes one parameter,

Signatures themselves are restricted to the top level parameters expected by a
method. For instance if a method expects one array of structs as a parameter,

And most likely:

a client can call methods with parameters

Method has parameters, but it expects and takes arguments.

done. thank you

Comment thread Doc/library/xmlrpc.client.rst Outdated
Comment thread Doc/library/xmlrpc.client.rst Outdated
Comment thread Doc/library/xmlrpc.client.rst Outdated
@serhiy-storchaka serhiy-storchaka requested a review from a team October 27, 2025 16:57
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 27, 2025
@hugovk

hugovk commented Oct 28, 2025

Copy link
Copy Markdown
Member

In June, the editorial board recommended not to make similar changes:

#135160 (comment)

@efimov-mikhail

Copy link
Copy Markdown
Member

In June, the editorial board recommended not to make similar changes:

#135160 (comment)

So, what should we do? Close this PR and corresponding issue?

@serhiy-storchaka

Copy link
Copy Markdown
Member

Even if we consider the terms "argument" and "parameter" interchangeable (I think this would be a great mistake), this PR contains other improvements. And if "argument" and "parameter" are the same, it will not harm to change one to other, isn't?

@hugovk

hugovk commented Nov 19, 2025

Copy link
Copy Markdown
Member

... this PR contains other improvements.

How about just make those improvements?

@efimov-mikhail

Copy link
Copy Markdown
Member

Is it correct that we have closed the issue without merging or closing this PR?

@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 1, 2026
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 30, 2026
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge docs Documentation in the Doc dir needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes skip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

6 participants