Skip to content

bpo-30262: Don't expose sqlite Cache and Statement #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berkerpeksag merged 5 commits into from
May 9, 2019
Merged

bpo-30262: Don't expose sqlite Cache and Statement #1440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6e4750
Don't expose sqlite3 Cache and Statement
palaviv May 3, 2017
d734497
Add NEWS entry
palaviv May 9, 2019
a114789
Add not to 3.8 whatsnew
palaviv May 9, 2019
e21fe1d
Update 2019-05-09-12-38-40.bpo-30262.Tu74ak.rst
berkerpeksag May 9, 2019
72c5e69
Update 3.8.rst
berkerpeksag May 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Doc/whatsnew/3.8.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,6 +783,10 @@ The following features and APIs have been removed from Python 3.8:
* "unicode_internal" codec is removed.
(Contributed by Inada Naoki in :issue:`36297`.)

* The ``Cache`` and ``Statement`` objects of the :mod:`sqlite3` module are not
exposed to the user.
(Contributed by Aviv Palivoda in :issue:`30262`.)


Porting to Python 3.8
=====================
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2019-05-09-12-38-40.bpo-30262.Tu74ak.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
The ``Cache`` and ``Statement`` objects of the :mod:`sqlite3` module are not
exposed to the user. Patch by Aviv Palivoda.
4 changes: 0 additions & 4 deletions Modules/_sqlite/module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,10 +366,6 @@ PyMODINIT_FUNC PyInit__sqlite3(void)
PyModule_AddObject(module, "Connection", (PyObject*) &pysqlite_ConnectionType);
Py_INCREF(&pysqlite_CursorType);
PyModule_AddObject(module, "Cursor", (PyObject*) &pysqlite_CursorType);
Py_INCREF(&pysqlite_CacheType);
PyModule_AddObject(module, "Statement", (PyObject*)&pysqlite_StatementType);
Py_INCREF(&pysqlite_StatementType);
PyModule_AddObject(module, "Cache", (PyObject*) &pysqlite_CacheType);
Py_INCREF(&pysqlite_PrepareProtocolType);
PyModule_AddObject(module, "PrepareProtocol", (PyObject*) &pysqlite_PrepareProtocolType);
Py_INCREF(&pysqlite_RowType);
Expand Down