Skip to content

[3.8] bpo-37322: Fix test_ssl.test_pha_required_nocert() ResourceWarning (GH-14662)#14665

Closed
miss-islington wants to merge 1 commit into
python:3.8from
miss-islington:backport-cf9c41c-3.8
Closed

[3.8] bpo-37322: Fix test_ssl.test_pha_required_nocert() ResourceWarning (GH-14662)#14665
miss-islington wants to merge 1 commit into
python:3.8from
miss-islington:backport-cf9c41c-3.8

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 9, 2019

Copy link
Copy Markdown
Contributor

Close the TLS connection in test_pha_required_nocert() of test_ssl to
fix a ResourceWarning.
(cherry picked from commit cf9c41c)

Co-authored-by: Victor Stinner [email protected]

https://bugs.python.org/issue37322

…ythonGH-14662)

Close the TLS connection in test_pha_required_nocert() of test_ssl to
fix a ResourceWarning.
(cherry picked from commit cf9c41c)

Co-authored-by: Victor Stinner <[email protected]>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a failure ❌ .

@vstinner

vstinner commented Jul 9, 2019

Copy link
Copy Markdown
Member

The test failed on Windows, I cancel the backport.

@vstinner vstinner closed this Jul 9, 2019
@miss-islington miss-islington deleted the backport-cf9c41c-3.8 branch July 9, 2019 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants