gh-149358: Generating JIT recorder transformers and stabilizing family layouts#149359
gh-149358: Generating JIT recorder transformers and stabilizing family layouts#149359cocolato wants to merge 8 commits into
Conversation
Documentation build overview
|
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
Could do with a couple more tests, but looks good otherwise
| op(_DO_STUFF, (tos -- res)) { | ||
| res = tos; | ||
| } | ||
| macro(OP) = _RECORD_TOS + _DO_STUFF; |
There was a problem hiding this comment.
Can you add tests for:
- Base op does not record, but specialization does
- Base op does record, but specialization does not
| size: str | ||
| members: list[Instruction] | ||
|
|
||
| @property |
There was a problem hiding this comment.
Can you make this a normal function? It is quite heavyweight for a property
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks for review ! I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @markshannon: please review the changes made to this pull request. |
2 participants
Refer #148730 (comment) and can also help we fix the issue in: #148745