Skip to content

bpo-40014: Skip os.getgrouplist related test if OSError is raised. #19075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
corona10 wants to merge 5 commits into from
Closed

bpo-40014: Skip os.getgrouplist related test if OSError is raised. #19075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84d2ab9
bpo-40014: Skip adding os.getgrouplist info if error is raised
corona10 Mar 19, 2020
29ebba5
bpo-40014: Update test_posix
corona10 Mar 19, 2020
2788493
bpo-40014: Update NEWS.d
corona10 Mar 19, 2020
cd8fc55
bpo-40014: Update NEWS.d
corona10 Mar 19, 2020
ec921ea
bpo-40014: Apply Victors's code review.
corona10 Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Lib/test/pythoninfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,9 +333,13 @@ def collect_pwd(info_add):
return

if hasattr(os, 'getgrouplist'):
groups = os.getgrouplist(entry.pw_name, entry.pw_gid)
groups = ', '.join(map(str, groups))
info_add('os.getgrouplist', groups)
try:
groups = os.getgrouplist(entry.pw_name, entry.pw_gid)
groups = ', '.join(map(str, groups))
except OSError:
pass
else:
info_add('os.getgrouplist', groups)


def collect_readline(info_add):
Expand Down
11 changes: 9 additions & 2 deletions Lib/test/test_posix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,8 +1025,15 @@ def _create_and_do_getcwd(dirname, current_path_length = 0):
def test_getgrouplist(self):
user = pwd.getpwuid(os.getuid())[0]
group = pwd.getpwuid(os.getuid())[3]
self.assertIn(group, posix.getgrouplist(user, group))

try:
self.assertIn(group, posix.getgrouplist(user, group))
except OSError as e:
# bpo-40014: getgrouplist fails with
# "[Errno 25] Inappropriate ioctl for device" on macOS
if sys.platform == 'darwin':
raise unittest.SkipTest("bpo-40014: os.getgrouplist() is not available")
else:
raise e

@unittest.skipUnless(hasattr(os, 'getegid'), "test needs os.getegid()")
def test_getgroups(self):
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Tests/2020-03-20-01-12-30.bpo-40014.h9SHIQ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
test.pythoninfo: skip :func:`~os.getgrouplist` if it raises an :exc:`OSError`.
Patch by Dong-hee Na.