Skip to content

bpo-43271: Re-enable ceval.c optimizations for Windows debug builds#24739

Merged
gvanrossum merged 1 commit into
python:masterfrom
db3l:bpo-43271
Mar 4, 2021
Merged

bpo-43271: Re-enable ceval.c optimizations for Windows debug builds#24739
gvanrossum merged 1 commit into
python:masterfrom
db3l:bpo-43271

Conversation

@db3l

@db3l db3l commented Mar 4, 2021

Copy link
Copy Markdown
Contributor

Partially reverts commit b74396c

The optimizations are necessary to prevent the interpreter from
crashing in a number of tests involving recursion.

https://bugs.python.org/issue43271

Partially reverts commit b74396c

The optimizations are necessary to prevent the interpreter from
crashing in a number of tests involving recursion.

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gvanrossum

Copy link
Copy Markdown
Member

Please do add a blurb.

@db3l

db3l commented Mar 4, 2021

Copy link
Copy Markdown
Contributor Author

Are you sure a blurb would be helpful? I sort of figured it might be confusing as this just re-establishes preexisting behavior, plus the blurb for the original change being reverted was skipped.

@gvanrossum

Copy link
Copy Markdown
Member

Okay, there was no blurb for the original, so let's just merge it.

@gvanrossum gvanrossum merged commit 131d551 into python:master Mar 4, 2021
@db3l db3l deleted the bpo-43271 branch March 4, 2021 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants