gh-91325: Skip Stable ABI checks with Py_TRACE_REFS special build#92046
Merged
Conversation
This build is not compatible with Py_LIMITED_API nor with the stable ABI.
encukou
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
kumaraditya303
previously requested changes
Dec 13, 2022
kumaraditya303
left a comment
kumaraditya303
left a comment
Contributor
There was a problem hiding this comment.
There are merge conflicts.
|
When you're done making the requested changes, leave the comment: And if you don't make the requested changes, you will be poked with soft cushions! |
Member
Author
|
... where are my soft cushions, @bedevere-bot ? |
encukou
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
Member
Author
|
No soft cushions, so I've resolved the conflict. |
Member
Author
|
I have made the requested changes; please review again |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…ld (pythonGH-92046) Skip Stable ABI checks with Py_TRACE_REFS special build This build is not compatible with Py_LIMITED_API nor with the stable ABI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Py_TRACE_REFS is not compatible with Py_LIMITED_API nor with the stable ABI.