mailbox: Fix signature of Mailbox.update method#3493
Merged
Conversation
The `update` method calls `self[key] = message` for each `(key, message)` pair so it also accepts all the same message types as the `__setitem__` method. Fix the signature so that the inputs are not restricted to `Message` instances or to instance of the `_MessageType` type parameter, but to the more reluctant `_MessageData` type alias.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
updatemethod callsself[key] = messagefor each(key, message)pair so it also accepts all the same message types as the
__setitem__method. Fix the signature so that the inputs are not restricted to
Messageinstances or to instance of the_MessageTypetype parameter,but to the more reluctant
_MessageDatatype alias.