dimensionality fix for OrderedDict for Python 2.7. Issue #167#175
dimensionality fix for OrderedDict for Python 2.7. Issue #167#175vrindger wants to merge 2 commits into
Conversation
|
Unfortunately, this is breaking some tests - see https://travis-ci.org/github/python-quantities/python-quantities/builds/681112615 (I don't know why the Travis results aren't showing up here in the PR) |
|
I just looked at one and it already looks pretty serious: https://travis-ci.org/github/python-quantities/python-quantities/jobs/681112616 I'm not sure how else could we fix this issue then. FAIL: test_std (quantities.tests.test_methods.TestQuantityMethods)Traceback (most recent call last): |
|
Hi @apdavison , |
|
@vrindger I've added a "Python 2.7 + Numpy 1.15.1" entry to the test matrix (we actually get Python Python 2.7.17 not 2.7.15, but I don't believe that will make any difference). This combination passes on the master branch. I think you'll have to add a commit to this PR to trigger the tests to run again with the new Numpy 1.15.1 test. |
|
Thanks @apdavison I triggered a fresh set of Travis tests with a non-change commit. ERROR: test_backward_compat (quantities.tests.test_persistence.TestPersistence) |
|
@vrindger sorry we didn't get this merged. We've now dropped support for Python 2.7, so I'm closing this PR now. |
Here's the change proposed for #167. This fixed the issue and passed tests when I was testing it locally. Please approve and release as soon as feasible. This has become critical for us again. Thanks!