Support .NET Framework 4.6.1#2701
Conversation
|
@filmor tested this with my end users, it indeed works just fine |
|
Are any tests expected for this PR? |
|
My bad, I should've checked the behavior on .NET Core too. @filmor could you please approve the workflows to run again? |
|
Bump, just need tests to be approved to run. |
|
Is there any way I can help speed up the review/merge? |
|
@filmor sorry for bothering, any ETA on the merge? |
|
Two issues:
|
|
|
Well, I don't want to join the large-package-size cohort if not necessary. Wheel variants don't exist, yet (there is an open PEP on this), otherwise that would have been the preferred way. I think I will simply add a Windows wheel build that includes the .NET 4.6, then at least we don't carry all of the shim DLLs around on other platforms. @lostmsu, what is your take on this? |
|
I feel like I am missing something, is 1.6 MB really that large? to me it looks like an increase from microscopic to just small 🤔 That works too, of course, just wondering if there's really a point in keeping it separate. |
| Default on Windows and also only supported there. Must be at least version | ||
| 4.6.1, with 4.7.2 or later recommended. | ||
| 4.6.1, with 4.7.2 or later recommended. For .NET 4.6 support, the wheel has | ||
| to be built with the environment variable `PYTHONNET_BUILD_NET46_SUPPORT=1`. |
There was a problem hiding this comment.
seems to be outdated now, judging by uv build --wheel -C="--global-option=--net46-support" below
What does this implement/fix? Explain your changes.
net461assemblies.configis not really accessiblePython.Runtime.dllDoes this close any currently open issues?
Closes #2695
Any other comments?
Requires merge of pythonnet/clr-loader#114
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG