Skip to content

Duplicate references cause script execution to fail #953

@adamralph

Description

@adamralph

image

This is in the current release, i.e. 0.13.3 on Choco.

IIRC, we had some kind of 'de-duplication' of references at one time but it seems to have disappeared. I think what we require is a more general version of the changes that went into the dev branch recently for the scriptcs assemblies (

.Where(assembly =>
assembly != typeof(ScriptExecutor).Assembly && assembly != typeof(IScriptEnvironment).Assembly))
and
.Where(path =>
!string.Equals(
Path.GetFileName(path),
Path.GetFileName(typeof(ScriptExecutor).Assembly.Location),
StringComparison.OrdinalIgnoreCase) &&
!string.Equals(
Path.GetFileName(path),
Path.GetFileName(typeof(IScriptEnvironment).Assembly.Location),
StringComparison.OrdinalIgnoreCase)))
) which take into account all the assemblies currently referenced.

Unless we can push out 0.14 soon I think this should be a patch on master (0.13.4) but I'd prefer someone else to reproduce and confirm the issue first.

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions