Skip to content

Added :scriptpacks REPL command#1005

Merged
adamralph merged 9 commits into
scriptcs:devfrom
filipw:feature/scriptpackscommand
Apr 4, 2015
Merged

Added :scriptpacks REPL command#1005
adamralph merged 9 commits into
scriptcs:devfrom
filipw:feature/scriptpackscommand

Conversation

@filipw

@filipw filipw commented Mar 28, 2015

Copy link
Copy Markdown
Member

Allows to easily inspect the script packs available in the REPL context.

  • prints method signatures (including extension methods)
  • prints property definitions (including correct getter/setter)
  • uses fully qualified type names if the given namespace is not imported into REPL context, if it is imported uses simple type name

Example:
screenshot 2015-03-28 23 31 51

@filipw

filipw commented Mar 29, 2015

Copy link
Copy Markdown
Member Author

why do we even have travis if it fails all the time ;)

@adamralph

adamralph commented Mar 29, 2015

Copy link
Copy Markdown
Contributor

It passes in about 1 run of out 10 😉

Hopefully this will get rid of the problem #1001

@glennblock

glennblock commented Mar 29, 2015

Copy link
Copy Markdown
Contributor

@filipw I share your pain. We need to do something and hopefully #1001
fixes. If not, we need to make other plans.
On Sun, Mar 29, 2015 at 5:39 AM Adam Ralph [email protected] wrote:

It passes in about 1 run of out 10 [image: 😉]

Hopefully this will get rid of the problem #1001
#1001

—
Reply to this email directly or view it on GitHub
#1005 (comment).

@filipw filipw mentioned this pull request Mar 30, 2015
Open
@filipw

filipw commented Apr 2, 2015

Copy link
Copy Markdown
Member Author

anyone?

@adamralph

adamralph commented Apr 2, 2015

Copy link
Copy Markdown
Contributor

My last few days have been chaotic, but I can look at the weekend unless someone beats me to it.

@adamralph adamralph self-assigned this Apr 3, 2015
adamralph
adamralph reviewed Apr 3, 2015
View reviewed changes
Comment thread src/ScriptCs.Core/ReplCommands/ScriptPacksCommand.cs Outdated

@adamralph adamralph Apr 3, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be moved down to inside the conditional, just before writing out the message to say there are no script packs. (See further comment below).

@adamralph adamralph assigned filipw and unassigned adamralph Apr 3, 2015
@adamralph adamralph added the hold label Apr 3, 2015
@adamralph adamralph assigned adamralph and unassigned filipw Apr 4, 2015
@adamralph adamralph removed the hold label Apr 4, 2015
adamralph added a commit that referenced this pull request Apr 4, 2015
@adamralph
Merge pull request #1005 from filipw/feature/scriptpackscommand
260e068 
Added :scriptpacks REPL command
@adamralph adamralph merged commit 260e068 into scriptcs:dev Apr 4, 2015
@adamralph

adamralph commented Apr 4, 2015

Copy link
Copy Markdown
Contributor

nice @filipw, I love this new command

@adamralph adamralph added this to the v0.15 milestone Apr 4, 2015
@adamralph

adamralph commented Apr 4, 2015

Copy link
Copy Markdown
Contributor

I've given it pride of place in the 0.15 release notes 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@adamralph adamralph

Labels

feature

Projects

None yet

Milestone

v0.15

Development

Successfully merging this pull request may close these issues.

3 participants

@filipw @adamralph @glennblock