Do not use initialize modules MEF catalog if the only module in play is Roslyn or Mono#965
Merged
Conversation
Contributor
|
Awesome @filipw! Although the docker based Travis CI config is a vast improvement, it still fails with the intermittent xunit output path issue 😒. Re-running... |
adamralph
added a commit
that referenced
this pull request
Mar 7, 2015
Do not use initialize modules MEF catalog if the only module in play is Roslyn or Mono
Contributor
|
Added #964 to the 0.14 release notes |
Contributor
|
I've tested locally and my total time to start REPL in an empty folder has gone from ~2 seconds to ~1 second :fistbump: |
Member
Author
|
I wonder why is it that slow for you though, you have seen the profiler results (against debug build and started from VS) and it's ~500ms. And that's in a VM! |
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #964
Great perf benefit - improves startup from ~1.5s to ~0.5s.
Tested on Win and OS X