Fixes rare exception when using GetLocalizedPropertyCollection with large entity IDs array

mgesing · mgesing · commit 5573cc721be8 · 2022-05-27T10:42:23.000+02:00
diff --git a/src/Libraries/SmartStore.Services/Localization/LocalizedEntityService.cs b/src/Libraries/SmartStore.Services/Localization/LocalizedEntityService.cs
@@ -218,6 +218,7 @@ protected virtual LocalizedPropertyCollection GetLocalizedPropertyCollectionInte
                             where x.LocaleKeyGroup == localeKeyGroup
                             select x;
 
+                var splitEntityIds = false;
                 var requestedSet = entityIds;
 
                 if (entityIds != null && entityIds.Length > 0)
@@ -243,7 +244,15 @@ protected virtual LocalizedPropertyCollection GetLocalizedPropertyCollectionInte
                     else
                     {
                         requestedSet = entityIds;
-                        query = query.Where(x => entityIds.Contains(x.EntityId));
+
+                        if (entityIds.Length > 5000)
+                        {
+                            splitEntityIds = true;
+                        }
+                        else
+                        {
+                            query = query.Where(x => entityIds.Contains(x.EntityId));
+                        }
                     }
                 }
 
@@ -252,7 +261,20 @@ protected virtual LocalizedPropertyCollection GetLocalizedPropertyCollectionInte
                     query = query.Where(x => x.LanguageId == languageId);
                 }
 
-                return new LocalizedPropertyCollection(localeKeyGroup, requestedSet, query.ToList());
+                if (splitEntityIds)
+                {
+                    var items = new List<LocalizedProperty>();
+                    foreach (var chunk in entityIds.Slice(5000))
+                    {
+                        items.AddRange(query.Where(x => chunk.Contains(x.EntityId)).ToList());
+                    }
+
+                    return new LocalizedPropertyCollection(localeKeyGroup, requestedSet, items);
+                }
+                else
+                {
+                    return new LocalizedPropertyCollection(localeKeyGroup, requestedSet, query.ToList());
+                }
             }
         }
 
