fix(web): resolve TypeScript build errors for chat preferences

adam.wilson · cursoragent · adam.wilson · commit 89b0e925af09 · 2026-05-28T11:36:27.000+01:00
`next build` (which runs `tsc` strictly) caught three issues that the looser ESLint pass missed. None are behavior changes — all are type-correctness fixes. 1. `chatPreferencesPage.tsx`: `toggleVariants` only defines `size: { default: ... }` (an icon-sized square), so `size="sm"` on `<ToggleGroup>` was a type error. Removed the prop and overrode sizing on each `<ToggleGroupItem>` via `className="h-9 w-auto min-w-0 px-3"` so the text labels actually fit. 2. `features/chat/actions.ts` and `app/api/(server)/chat/route.ts`: `chatPreferencesSchema` is built dynamically with `z.enum(string[])`, which widens each level value to `string` in the inferred type. Assigning `parsed.data` to the narrower `ChatPreferences` literal-union map therefore failed strict typecheck. Added an `as ChatPreferences` cast in both consumers with a comment explaining why the cast is sound (runtime validation still constrains each value to its per-dimension level list). 3. `__mocks__/prisma.ts`: `MOCK_USER_WITH_ACCOUNTS` was missing the two new User fields. Added `chatPreferences: {}` and `chatCustomInstructions: null` so test code compiles against the updated Prisma type. Refs #1242, #1243 Co-authored-by: Cursor <cursoragent@cursor.com>
diff --git a/packages/web/src/__mocks__/prisma.ts b/packages/web/src/__mocks__/prisma.ts
@@ -42,6 +42,8 @@ export const MOCK_USER_WITH_ACCOUNTS: User & { accounts: Account[] } = {
     emailVerified: null,
     image: null,
     sessionVersion: 0,
+    chatPreferences: {},
+    chatCustomInstructions: null,
     accounts: [],
 }
 
diff --git a/packages/web/src/app/(app)/settings/chatPreferences/chatPreferencesPage.tsx b/packages/web/src/app/(app)/settings/chatPreferences/chatPreferencesPage.tsx
@@ -152,7 +152,6 @@ export function ChatPreferencesPage({
                                 value={currentValue}
                                 onValueChange={(value) => handleDimensionChange(dimension, value)}
                                 variant="outline"
-                                size="sm"
                                 className="flex-wrap justify-start gap-2"
                                 aria-label={spec.label}
                             >
@@ -161,6 +160,7 @@ export function ChatPreferencesPage({
                                         key={level.value}
                                         value={level.value}
                                         aria-label={`${spec.label}: ${level.label}`}
+                                        className="h-9 w-auto min-w-0 px-3"
                                     >
                                         {level.label}
                                     </ToggleGroupItem>
diff --git a/packages/web/src/app/api/(server)/chat/route.ts b/packages/web/src/app/api/(server)/chat/route.ts
@@ -108,8 +108,14 @@ export const POST = apiHandler(async (req: NextRequest) => {
                 });
                 if (row) {
                     const parsed = chatPreferencesSchema.safeParse(row.chatPreferences);
+                    // Cast back to the narrower literal-union map: the schema
+                    // is built dynamically so its inferred type widens to
+                    // `string`, but the runtime validation still constrains
+                    // each value to its per-dimension level list.
                     userPreferences = {
-                        preferences: parsed.success ? parsed.data : {},
+                        preferences: parsed.success
+                            ? (parsed.data as ResolvedChatUserPreferences["preferences"])
+                            : {},
                         customInstructions: row.chatCustomInstructions,
                     };
                 }
diff --git a/packages/web/src/features/chat/actions.ts b/packages/web/src/features/chat/actions.ts
@@ -582,7 +582,13 @@ export const getChatPreferences = async (): Promise<{
         }
 
         const parsed = chatPreferencesSchema.safeParse(row.chatPreferences);
-        const preferences: ChatPreferences = parsed.success ? parsed.data : {};
+        // The schema is built with a dynamic `z.enum(string[])` so its inferred
+        // type widens each level to `string`. The runtime values are still
+        // validated against the per-dimension level lists, so the cast back to
+        // the narrower `ChatPreferences` literal-union map is sound.
+        const preferences: ChatPreferences = parsed.success
+            ? (parsed.data as ChatPreferences)
+            : {};
 
         return {
             preferences,

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,8 @@ export const MOCK_USER_WITH_ACCOUNTS: User & { accounts: Account[] } = {`
`42`	`42`	`emailVerified: null,`
`43`	`43`	`image: null,`
`44`	`44`	`sessionVersion: 0,`
	`45`	`+ chatPreferences: {},`
	`46`	`+ chatCustomInstructions: null,`
`45`	`47`	`accounts: [],`
`46`	`48`	`}`
`47`	`49`