Skip to content

feat(vpn): basic connection commands#1433

Merged
cgoetz-inovex merged 7 commits into
mainfrom
feat/STACKITCLI-384-vpn-connection
Jun 12, 2026
Merged

feat(vpn): basic connection commands#1433
cgoetz-inovex merged 7 commits into
mainfrom
feat/STACKITCLI-384-vpn-connection

Conversation

@cgoetz-inovex

@cgoetz-inovex cgoetz-inovex commented Jun 9, 2026

Copy link
Copy Markdown
Contributor
  • implement create, describe, list, delete for vpn connection
  • add helpers for string based enum flags
  • make JoinStringPtr generic to accept string based enum slices

Description

relates to #1234

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@cgoetz-inovex
feat(vpn): basic connection commands
b3907e9 
- implement create, describe, list, delete for vpn connection
- add helpers for string based enum flags
- make JoinStringPtr generic to accept string based enum slices
@cgoetz-inovex cgoetz-inovex requested a review from a team as a code owner June 9, 2026 12:28
Fyusel
Fyusel reviewed Jun 12, 2026
View reviewed changes
Comment thread internal/cmd/beta/vpn/connection/create/create.go
Comment thread internal/cmd/beta/vpn/connection/connection.go
Comment thread internal/pkg/flags/string_enum.go
Comment thread internal/cmd/beta/vpn/connection/create/create.go Outdated
Fyusel
Fyusel previously approved these changes Jun 12, 2026
View reviewed changes
@cgoetz-inovex cgoetz-inovex enabled auto-merge (squash) June 12, 2026 11:55
@cgoetz-inovex cgoetz-inovex merged commit 7107ebc into main Jun 12, 2026
3 checks passed
@cgoetz-inovex cgoetz-inovex deleted the feat/STACKITCLI-384-vpn-connection branch June 12, 2026 12:08
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merging this branch changes the coverage (1 decrease, 6 increase)

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection/create 75.28% (+75.28%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection/delete 38.46% (+38.46%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection/describe 80.82% (+80.82%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection/list 67.44% (+67.44%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection/status 79.41% (+79.41%) 🌟
github.com/stackitcloud/stackit-cli/internal/pkg/config 70.11% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/flags 68.06% (+9.01%) 👍
github.com/stackitcloud/stackit-cli/internal/pkg/services/vpn/client 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/utils 53.72% (-4.32%) 👎
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/beta.go 0.00% (ø) 10 (+1) 0 10 (+1)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection/connection.go 0.00% (ø) 8 (+8) 0 8 (+8)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection/create/create.go 75.28% (+75.28%) 89 (+89) 67 (+67) 22 (+22) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection/delete/delete.go 38.46% (+38.46%) 39 (+39) 15 (+15) 24 (+24) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection/describe/describe.go 80.82% (+80.82%) 73 (+73) 59 (+59) 14 (+14) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection/list/list.go 67.44% (+67.44%) 43 (+43) 29 (+29) 14 (+14) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection/status/status.go 79.41% (+79.41%) 68 (+68) 54 (+54) 14 (+14) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/vpn.go 0.00% (ø) 4 (+4) 0 4 (+4)
github.com/stackitcloud/stackit-cli/internal/pkg/config/config.go 90.77% (ø) 65 59 6
github.com/stackitcloud/stackit-cli/internal/pkg/flags/string_enum.go 95.24% (+95.24%) 42 (+42) 40 (+40) 2 (+2) 🌟
github.com/stackitcloud/stackit-cli/internal/pkg/flags/string_enumslice.go 95.74% (+95.74%) 47 (+47) 45 (+45) 2 (+2) 🌟
github.com/stackitcloud/stackit-cli/internal/pkg/services/vpn/client/client.go 0.00% (ø) 1 (+1) 0 1 (+1)
github.com/stackitcloud/stackit-cli/internal/pkg/utils/strings.go 50.00% (-13.64%) 42 (+9) 21 21 (+9) 💀

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/vpn/connection/status/status_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/flags/string_enum_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/flags/string_enumslice_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fyusel Fyusel Fyusel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cgoetz-inovex @Fyusel