fix: accept normalize argument as object, too#332
Conversation
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
TypeScript error report:
Svelte TypeScript error report:
|
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-332
# or install the specific version
npm install [email protected] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb801ec168
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
TypeScript error report:
Svelte TypeScript error report:
|
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-332
# or install the specific version
npm install [email protected] |
|
TypeScript error report:
Svelte TypeScript error report:
|
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-332
# or install the specific version
npm install [email protected] |
|
TypeScript error report:
Svelte TypeScript error report:
|
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-332
# or install the specific version
npm install [email protected] |
1 participant
Both
normalizeXandnormalizeYnow accept an options object (e.g.,{ basis: 'sum' }) in addition to the previous string/function forms, allowing for more extensible and descriptive usage.Type Improvements
MapIndexFunctiontype alias for improved clarity and type safety, and updatedMapIndexObjectto use this alias.isMapIndex) to distinguish between options objects and map index objects, improving robustness in thenormalizefunction.normalizeBasisandnormalizeDeviation, for better maintainability and developer experience. [1] [2]Channel Renaming Fix
RENAMEexport inrename.tsfrom a string constant to a unique symbol, preventing potential collisions and making channel renaming more reliable.