feat: improve canvas tick mark rendering#352
Merged
Merged
Conversation
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
TypeScript error report:
Svelte TypeScript error report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendering and performance improvements
TickCanvas.svelteby batching drawing operations based on style, reducing redundant context state changes, and only flushing paths when styles change. This improves canvas rendering performance for plots with many ticks. [1] [2]normalizeLineCaphelper to ensure valid canvas line cap values, and refactored style preparation logic for clarity and maintainability. [1] [2]Example documentation updates
tick-x-canvas-vs-svg.svelteandtick-x.svelteto reference "Barcode plot" and provide attribution to Observable Plot, improving clarity for users and aligning with the chart's purpose. [1] [2]