fix: resolve svelte-check issues in sveltepress theme#398
Merged
Conversation
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-398
# or install the specific version
npm install [email protected] |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-398
# or install the specific version
npm install [email protected] |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-398
# or install the specific version
npm install [email protected] |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-398
# or install the specific version
npm install [email protected] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a large batch of theme-layer svelte-check and lint issues, mainly around route/path typing, virtual module typings, and stricter null/type safety in shared theme components.
Scope
PageSwitcher.svelte
ExampleGrid.svelte
ExamplesPageList.svelte
utils.ts
Validation
pnpm run lintpassed.pnpm run lint:typespassed.pnpm exec svelte-checkshows now issues in src/theme/components