Greptile Summary

This PR removes the custom recipient parameter from all four v4 swap methods and switches from the TAKE action to TAKE_ALL, which always delivers tokens to msg.sender. The ABI value-count mismatch flagged in the previous review round is now fixed (three-value lists reduced to two), but the numeric ABI type in settle_all_params and take_all_params is still declared as uint128 across all four methods while constants.py defines both SETTLE_ALL and TAKE_ALL as ["address", "uint256"].

Confidence Score: 4/5

Safe to merge for typical token amounts; the uint128/uint256 mismatch only becomes a problem for quantities above 2^128.

No P0 or P1 findings. The remaining uint128 vs uint256 issue is P2 — byte-identical encoding for all realistic amounts. Test coverage gap is a quality concern only.

All four swap methods in uniswap/uniswap4.py share the same uint128 type annotation inconsistency with the constants ABI definition.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant Caller
    participant Uniswap4
    participant UniversalRouter
    participant PoolManager

    Caller->>Uniswap4: eth_to_token_swap_input(input, qty, qtycap, ...)
    Note over Uniswap4: Build actions:<br/>SWAP_EXACT_IN_SINGLE / SETTLE_ALL / TAKE_ALL
    Uniswap4->>Uniswap4: encode settle_all_params([address, uint128])
    Uniswap4->>Uniswap4: encode take_all_params([address, uint128])
    Uniswap4->>UniversalRouter: execute(V4_SWAP, inputs)
    UniversalRouter->>PoolManager: swap(poolKey, params)
    PoolManager-->>UniversalRouter: output tokens
    UniversalRouter->>Caller: TAKE_ALL sends tokens to msg.sender

_{Reviews (2): Last reviewed commit: "quick fix" | Re-trigger Greptile}